INT-3328: fix disabled property with ngmodel#416
Merged
michalnieruchalski-tiugo merged 3 commits intomainfrom May 28, 2025
Merged
INT-3328: fix disabled property with ngmodel#416michalnieruchalski-tiugo merged 3 commits intomainfrom
michalnieruchalski-tiugo merged 3 commits intomainfrom
Conversation
hamza0867
approved these changes
May 27, 2025
tiny-ben-tran
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the reasons why I think it’s safe to remove
this._editor.isInitialized()check:Manual testing
It's safe to enter readonly mode/set disabled option before the editor has emitted 'init' event.
The lack of this check in different integrations
The origin of this check
It was introduced in 2018 and I believe it was just copied from other place of the file "just in case".
730975e
I believe it was copied from:
tinymce-angular/tinymce-angular-component/src/editor/editor.component.ts
Line 65 in 730975e
where it actually makes sense to not set the content before the editor is fully initialized.
TinyMCE code analysis
Both
EditorOptionsandModeclasses are being constructed insideEditorconstructor. Therefore I expect it’s safe to use these.